Skip to content

Fix MYSQLND_HAVE_SSL preprocessor help texts #16474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix MYSQLND_HAVE_SSL preprocessor help texts #16474

wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Oct 17, 2024

The MYSQLND_HAVE_SSL indicate that mysqlnd has extended SSL support enabled through either OpenSSL when building with Autotools, and through crypt32 library on Windows.

Fixes #15164 (comment)

@petk
Fix MYSQLND_HAVE_SSL preprocessor help texts
0d93872 
The MYSQLND_HAVE_SSL indicate that mysqlnd has extended SSL support
enabled through either OpenSSL when building with Autotools, and through
crypt32 library on Windows.

Fixes php#15164 (comment)
@petk petk requested a review from SakiTakamachi as a code owner October 17, 2024 07:32
@petk petk changed the base branch from master to PHP-8.4 October 17, 2024 07:32
@petk petk mentioned this pull request Oct 17, 2024
Merged
@cmb69
Copy link
Member

cmb69 commented Oct 17, 2024

Thank you!

From what I understand, MYSQLND_SSL_SUPPORTED allows to use encrypted connections, using the streams layers. It is always enabled (all platforms), because the streams layer will handle missing OpenSSL support during runtime. MYSQLND_HAVE_SSL is about caching SHA-2 pluggable authentication, and uses CNG on Windows, and OpenSSL on other systems, and only if the respective dependency is available during build time, the respective authentication plugins are enabled.

If my understanding is correct (please correct me otherwise), this PR is good, if we want to stick with the somewhat unclear wording ("core support" vs. "extended support").

Maybe @kamil-tekiela has something to say about this.

@kamil-tekiela
Copy link
Member

I have no opinion on this. Either way is fine.

cmb69
cmb69 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then I suggest to stick with what we have for now.

@cmb69 cmb69 closed this in 41347f0 Nov 10, 2024
@cmb69
Copy link
Member

cmb69 commented Nov 10, 2024

Thank you! Applied to PHP-8.4 and merged up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: mysqlnd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petk @cmb69 @kamil-tekiela